fix: Keep quantities in to_list of Cargo Movement search#562
Merged
alexspeddingvortexa merged 3 commits intomasterfrom Apr 17, 2026
Merged
fix: Keep quantities in to_list of Cargo Movement search#562alexspeddingvortexa merged 3 commits intomasterfrom
alexspeddingvortexa merged 3 commits intomasterfrom
Conversation
alexspeddingvortexa
changed the title
samhuk
approved these changes
Apr 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SDK’s Cargo Movement Pydantic model so that quantity-related fields returned by the API are preserved when converting search results to typed objects via .to_list() (instead of being dropped as undeclared extras).
Changes:
- Add 7 missing quantity/discharge quantity fields to
CargoMovementso Pydantic retains them during parsing. - Document unit behavior for
quantityvs explicit-unit quantity fields in the model. - Bump SDK version from
1.0.23to1.0.24.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
vortexasdk/version.py |
Version bump to publish the fix. |
vortexasdk/api/cargo_movement.py |
Declares missing quantity fields on the CargoMovement model so .to_list() retains them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CargoMovement model is a Pydantic BaseModel. When to_list() calls CargoMovement(**raw_dict), Pydantic only keeps fields that are declared on the model — anything else in the raw dict is silently dropped.
By adding the 7 missing fields to the model, Pydantic now recognises them during parsing and populates them instead of discarding them.